Deprecate cbook.report_memory. #20209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unrelated to Matplotlib's functionality, and more importantly it likely never worked on Py3 (currently raising "'int' object has no attribute 'split'") because the subprocess needs to be called with `universal_newlines=True`, otherwise (currently) stdout is returned as bytes and indexing that gives an int, not a str...
jklymak
approved these changes
May 12, 2021
timhoffm
approved these changes
May 12, 2021
|
bah, it's not as if there was any hurry... |
|
It’d be rather to not spam the deprecation log with unnecessary entries. But feel free to merge as is if you want the deprecation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unrelated to Matplotlib's functionality, and more importantly it
likely never worked on Py3 (currently raising "'int' object has no
attribute 'split'") because the subprocess needs to be called with
universal_newlines=True, otherwise (currently) stdout is returned asbytes and indexing that gives an int, not a str...
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).