Update span_selector.py #20212
Update span_selector.py #20212
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Updated span_selector and all checks passed |
|
Can you explain a bit more in the PR description what this does and why? Was this example broken before? |
|
The example was not robust enough. |
|
This is related to #20200; please give your PRs a summary as not everyone is going to remember and cross-reference every single issue. |
|
Okay, this is my first time contributing so didn't know. |
There was a problem hiding this comment.
Tip for future pull requests: If you write "Closes #20200" this will link the PR to the issue and also automatically close the issue when the PR gets merged. See also Linking a pull request to an issue using a keyword
|
Thanks @Jashshah6086! Congratulations on your first contribution to Matplotlib. We hope to see you again. |
…212-on-v3.4.x Backport PR #20212 on branch v3.4.x (Update span_selector.py)
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).