Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: Export sphinx-gallery run results to CircleCI. #20217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented May 13, 2021

PR Summary

This exports sphinx-gallery example run results to CircleCI, so we can get some idea of which examples fail often, etc., as in https://sphinx-gallery.github.io/stable/configuration.html#using-junit-xml-files

It probably won't amount to much, but might as well try it out.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak
Copy link
Member

jklymak commented May 16, 2021

Where can we see the results of this change?

@tacaswell
Copy link
Member

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can see the step in the logs, but not any of the results in the UI.

Not sure if this means we need this merged to the default branch to trigger things on the circle side or if it is configured wrong.

Given that this is only changes to CI config, I'm in favor of merging and finding out!

@jklymak jklymak merged commit de2ea8b into matplotlib:master May 17, 2021
@QuLogic QuLogic deleted the sg-junit branch May 17, 2021 19:53
@QuLogic
Copy link
Member Author

QuLogic commented May 17, 2021

Can see the step in the logs, but not any of the results in the UI.

Yes, it seems a bit in flux. On the build for this PR, I can see a Tests tab with 553 'results'. This also has a link to Insights which does work, though it only shows information for the one build. The information on pass/fail is probably irrelevant, but I think the stats on slowest tests might be useful. This may start working better for the main repo once it starts populating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants