FIX: correctly handle ax.legend(..., legendcolor='none') #20225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this would result in the label color being ignored because
colors.to_rgba_array('none') results in a 0 length array which in turn has
a 0 length cycle, which results in the zip over texts and colors terminating
before we have touched any of the texts, ignoring the color.
This makes::
ax.legend(..., legendcolor='none')
ax.legend(..., legendcolor=['none'])
behave the same
7 tasks
jklymak
approved these changes
May 14, 2021
jklymak
reviewed
May 14, 2021
| @@ -550,6 +550,9 @@ def __init__(self, parent, handles, labels, | |||
| break | |||
| except AttributeError: | |||
| pass | |||
| elif isinstance(labelcolor, str) and labelcolor == 'none': | |||
There was a problem hiding this comment.
I guess I'd have thought these were redundant....
There was a problem hiding this comment.
If a numpy array come is than elif obj == "none": gets us the "ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()" issue.
I thought about merging this with the conditional above, but was trying to avoid causing a rebase for @Carloscerq in #20084.
There was a problem hiding this comment.
Don’t worry about it. I think I can handle it over the weekend, and, if it’s the case, I can remake the #20084 .
QuLogic
approved these changes
May 15, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 15, 2021
…gendcolor='none')
QuLogic
added a commit
that referenced
this pull request
May 15, 2021
…225-on-v3.4.x Backport PR #20225 on branch v3.4.x (FIX: correctly handle ax.legend(..., legendcolor='none'))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously this would result in the label color being ignored because
colors.to_rgba_array('none') results in a 0 length array which in turn has
a 0 length cycle, which results in the zip over texts and colors terminating
before we have touched any of the texts, ignoring the color.
This makes::
behave the same
Discovered this while reviewing #20084 and trying to demonstrate the difference between
Noneand'none'in our color conventions.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).