Replace pgf image-streaming warning by error. #20248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saving a pgf file with images to an in-memory buffer (`import io; imshow([[1, 2]]); savefig(io.BytesIO(), format="pgf")`) currently warns that this is not possible (because the image needs to be written to the filesyste), but in fact an exception gets raised immediately after when trying to construct `Path(self.fh.name)`, so we may as well replace the original warning by an exception.
timhoffm
approved these changes
May 18, 2021
QuLogic
approved these changes
May 18, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 18, 2021
QuLogic
added a commit
that referenced
this pull request
May 18, 2021
…248-on-v3.4.x Backport PR #20248 on branch v3.4.x (Replace pgf image-streaming warning by error.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving a pgf file with images to an in-memory buffer
(
import io; imshow([[1, 2]]); savefig(io.BytesIO(), format="pgf"))currently warns that this is not possible (because the image needs to be
written to the filesyste), but in fact an exception gets raised
immediately after when trying to construct
Path(self.fh.name), so wemay as well replace the original warning by an exception.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).