Support imshow(<float16 array>). #20290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
May 24, 2021
| @@ -993,6 +993,13 @@ def test_empty_imshow(make_norm): | |||
| im.make_image(fig._cachedRenderer) | |||
|
|
|||
|
|
|||
| def test_imshow_float16(): | |||
| fig, ax = plt.subplots() | |||
| ax.imshow(np.zeros((3, 3), dtype=np.float16)) | |||
There was a problem hiding this comment.
This warns too? Should you check for the warning?
There was a problem hiding this comment.
No, this doesn't warn because it's an upcast (just like we don't warn for int->float).
(Unchecked warnings normally cause tests to fail, so this also tests that no warning is emitted.)
QuLogic
approved these changes
May 26, 2021
jklymak
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #15432. Supersedes #15436.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).