Further remove use of meshWidth, meshHeight in QuadMesh. #20302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
May 25, 2021
convert_mesh_to_paths and convert_mesh_to_triangles both rely on non-flat indexing of `coordinates`, and don't actually need the meshWidth and meshHeight arguments (they are only used in calls to reshape(), but reshape() can just use -1 for the unknown dimension). Instead of going through signature deprecation, just deprecate the methods, which are essentially helpers to generate calls to draw_quad_mesh and draw_gouraud_triangles.
timhoffm
approved these changes
May 25, 2021
|
|
QuLogic
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert_mesh_to_paths and convert_mesh_to_triangles both rely on
non-flat indexing of
coordinates, and don't actually need themeshWidth and meshHeight arguments (they are only used in calls to
reshape(), but reshape() can just use -1 for the unknown dimension).
Instead of going through signature deprecation, just deprecate the
methods, which are essentially helpers to generate calls to
draw_quad_mesh and draw_gouraud_triangles.
Followup to #20237.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).