Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove separate section for support of 3d subplots. #20394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2021
Merged

Remove separate section for support of 3d subplots. #20394

merged 1 commit into from
Jun 9, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 9, 2021

It's not "special" and doesn't warrant its own section; we can just
mention that in passing.

Also remove the "Getting started" section, which is by itself at its
level (see TOC at https://matplotlib.org/devdocs/tutorials/toolkits/mplot3d.html).

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@timhoffm timhoffm added this to the v3.5.0 milestone Jun 9, 2021
@anntzer
Copy link
Contributor Author

anntzer commented Jun 9, 2021

rebased

@timhoffm
Copy link
Member

timhoffm commented Jun 9, 2021

Doc build failure:

/home/circleci/project/doc/tutorials/introductory/sample_plots.rst:128: WARNING: Failed to create a cross reference. A title or caption not found: toolkit_mplot3d-tutorial
/home/circleci/project/doc/users/prev_whats_new/whats_new_0.99.rst:25: WARNING: Failed to create a cross reference. A title or caption not found: toolkit_mplot3d-tutorial
/home/circleci/project/doc/users/prev_whats_new/whats_new_1.1.rst:141: WARNING: Failed to create a cross reference. A title or caption not found: toolkit_mplot3d-tutorial

@anntzer
Copy link
Contributor Author

anntzer commented Jun 9, 2021

thanks for pointing it out, should be fixed.

tacaswell
tacaswell approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can merge on docs green.

@timhoffm
Copy link
Member

timhoffm commented Jun 9, 2021

Still one to go:

/home/circleci/project/doc/users/prev_whats_new/whats_new_1.1.rst:141: WARNING: unknown document: /tutorial/toolkits/mplot3d

@anntzer
Remove separate section for support of 3d subplots.
cf80d89 
It's not "special" and doesn't warrant its own section; we can just
mention that in passing.

Also remove the "Getting started" section, which is by itself at its
level.
@anntzer
Copy link
Contributor Author

anntzer commented Jun 9, 2021

woops.

@jklymak jklymak merged commit e4670d0 into matplotlib:master Jun 9, 2021
@anntzer anntzer deleted the 3ds branch June 9, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@WeatherGod WeatherGod WeatherGod approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation topic: mplot3d
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @timhoffm @tacaswell @WeatherGod @jklymak