Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pathing issue #20395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Pathing issue #20395

merged 2 commits into from
Jun 11, 2021

Conversation

diegopetrola
Copy link
Contributor

@diegopetrola diegopetrola commented Jun 9, 2021

PR Summary

PR Checklist

Closes #20328

What I did:

I will wait for the automated checks to pass before asking for a review.
Edit: ready for review.

@diegopetrola diegopetrola marked this pull request as draft June 9, 2021 16:01
@diegopetrola diegopetrola marked this pull request as ready for review June 9, 2021 19:02
@tacaswell tacaswell added this to the v3.5.0 milestone Jun 9, 2021
@@ -410,6 +410,16 @@ def test_path_intersect_path(phi):
b = transform.transform_path(Path([(0, 1), (0, 2), (0, 5)]))
assert a.intersects_path(b) and b.intersects_path(a)

# test added to adress issue #20328
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you say what #20328 was? This code may outlive GitHub and this comment won't be helpful...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, I rewrote the comments to be more alike the ones already present in the tests.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the nit about the comment...

@jklymak jklymak merged commit 3cf46cb into matplotlib:master Jun 11, 2021
@jklymak
Copy link
Member

jklymak commented Jun 11, 2021

Thanks @diegopetrola!

@QuLogic
Copy link
Member

QuLogic commented Jun 11, 2021

Did you not want this backported?

@jklymak
Copy link
Member

jklymak commented Jun 11, 2021

(me? I'm fine if we back port, but didn't think it was a regression...)

@QuLogic
Copy link
Member

QuLogic commented Jun 11, 2021

Yes, you milestoned the closed issue for 3.4.3.

@jklymak
Copy link
Member

jklymak commented Jun 11, 2021

@meeseeksdev backport to 3.4.3

@jklymak jklymak modified the milestones: v3.5.0, v3.4.3 Jun 11, 2021
@lumberbot-app
Copy link

lumberbot-app bot commented Jun 11, 2021

Something went wrong ... Please have a look at my logs.

It seem that the branch you are trying to backport to does not exists.

@jklymak
Copy link
Member

jklymak commented Jun 11, 2021

@meeseeksdev backport to 3.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 11, 2021

Something went wrong ... Please have a look at my logs.

It seem that the branch you are trying to backport to does not exists.

@jklymak
Copy link
Member

jklymak commented Jun 11, 2021

@meeseeksdev backport to v3.4.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 11, 2021
jklymak added a commit that referenced this pull request Jun 11, 2021
…395-on-v3.4.x

Backport PR #20395 on branch v3.4.x (Pathing issue)
@diegopetrola diegopetrola deleted the pathing-issue branch June 12, 2021 00:18
jklymak pushed a commit to jklymak/matplotlib that referenced this pull request Jun 13, 2021
* added check for collinearity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path.intersects_path sometimes returns incorrect values
4 participants