Set the axes of legend text #20458
Merged
Set the axes of legend text #20458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Jun 17, 2021
lib/matplotlib/legend.py
Outdated
| @@ -743,6 +743,7 @@ def _init_legend_box(self, handles, labels, markerfirst=True): | |||
| label_prop = dict(verticalalignment='baseline', | |||
| horizontalalignment='left', | |||
| fontproperties=self.prop, | |||
| axes=self.axes | |||
There was a problem hiding this comment.
I guess that is one soon. However, why doesn't it get set when the artist is added to the axes?
There was a problem hiding this comment.
I've updated it to set the axes of ._legend_box, which automatically sets the axes of its children. I think this is more general solution?
|
What does this do in the case of figure level legends? |
|
jklymak
approved these changes
Jun 17, 2021
tacaswell
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously the text added in a legend had
.axes == None. Fixes #20435Not sure if this needs a changelog entry?
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).