Make lack of support more explicit for non-postscript fonts + usetex. #20474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The info-level log can easily be hidden, and the KeyError may look like a bug on Matplotlib's side. Instead, explicitly raise an exception whose error message states that Matplotlib doesn't currently support certain cases. Use a LookupError (a parent class of KeyError, so a slight API break) rather than a KeyError as KeyError formats its argument as if it was the missing key (calling repr on it), which would not be the case here.
|
Your slight API-change has broken the test 😆. Need to catch the LookupError there. Otherwise, this is a reasonable change. |
|
Yup, should be fixed now... |
tacaswell
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The info-level log can easily be hidden, and the KeyError may look like
a bug on Matplotlib's side. Instead, explicitly raise an exception
whose error message states that Matplotlib doesn't currently support
certain cases. (#20469)
Use a LookupError (a parent class of KeyError, so a slight API break)
rather than a KeyError as KeyError formats its argument as if it was the
missing key (calling repr on it), which would not be the case here.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).