Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate Colorbar.patch. #20481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2021
Merged

Deprecate Colorbar.patch. #20481

merged 1 commit into from
Jul 8, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 22, 2021

It is not used at all anymore (its vertices are not even set correctly)
since the switch to ColorbarAxes.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer added this to the v3.5.0 milestone Jun 22, 2021
greglucas
greglucas approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the 20054-JMK filenames only used for organization/reference by the release manager, or do they need to be strictly associated with a PR#?

@QuLogic
Copy link
Member

QuLogic commented Jun 23, 2021

Think I'll wait to see what happens with #20484 (comment)

@jklymak jklymak marked this pull request as draft June 24, 2021 15:05
@jklymak
Copy link
Member

jklymak commented Jun 24, 2021

I think this is probably reasonable, but #20501 will change this I think...

@anntzer
Deprecate Colorbar.patch.
92a3fc4 
It is not used at all anymore (its vertices are not even set correctly)
since the switch to ColorbarAxes.
@anntzer anntzer marked this pull request as ready for review July 8, 2021 06:53
@timhoffm
Copy link
Member

timhoffm commented Jul 8, 2021

Anybody can merge after CI pass

@anntzer anntzer merged commit f230ce1 into matplotlib:master Jul 8, 2021
@anntzer anntzer deleted the cbp branch July 8, 2021 11:09
@larsoner larsoner mentioned this pull request Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
topic: color/colorbar
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @QuLogic @jklymak @timhoffm @greglucas