backend_gtk: don't hide FileChooserDialog; closes #1530 #2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiding the FileChooserDialog was pointless, because a new one is created each time the Save Figure button is clicked in the Toolbar. Hiding seems to have prevented the widget from being destroyed based on refcount, and this led to heavy access to the recently-used.xbel file with every subsequent keystroke.
|
👍 from me. I'm willing to merge this provided we can check that it hasn't had cross platform adverse affects in the release candidate. I propose we explicitly ask for release candidate testers to reply to the RC announcement with their OS, python version, numpy version and backends tested. |
|
Yeah -- I agree. Let's get this in the release candidate to give it lots of testing, and fix or revert as necessary before the final release. |
mdboom
added a commit
that referenced
this pull request
May 24, 2013
backend_gtk: don't hide FileChooserDialog; closes #1530
|
@efiring: Unfortunately, it now appears that the file save dialog never goes away. It saves the file, but the dialog remains open and responsive after clicking the Save button. This is on Fedora 18. Can you confirm on your system? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiding the FileChooserDialog was pointless, because a
new one is created each time the Save Figure button is
clicked in the Toolbar. Hiding seems to have prevented
the widget from being destroyed based on refcount, and this
led to heavy access to the recently-used.xbel file with
every subsequent keystroke.