Use set_xticks(ticks, labels) instead of a separate set_xticklabels() #20636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
981dd24 to
50fa443
Compare
story645
approved these changes
Jul 14, 2021
| ax2.set_yticks(pos) | ||
| # Set the tick locations and labels | ||
| ax2.set_yticks( | ||
| pos, labels=[format_score(scores[k].score, k) for k in test_names]) |
There was a problem hiding this comment.
not sure if wrapping format_score in a funcformatter would be helpful here or there's already too much going on in this example
There was a problem hiding this comment.
There are some more cleanups to be done in that example. I've made a note to have a look at it later. For simplicity, I'll keep this PR as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Split out of #20631 for easier review.