Small simplifications to FixedAxisArtistHelper. #20638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I fixed the doc build failue as part of #20632. Please rebase on master. |
timhoffm
approved these changes
Jul 13, 2021
QuLogic
approved these changes
Jul 17, 2021
- change_tick_coords has never been used by any other function or in any example in the library's history, and is a custom API not even present on other AxisArtistHelpers, so deprecate it. - _limits_inverted is only used in get_tick_iterators, so one can just test limits inversion there instead of carrying one bit of state around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example in the library's history, and is a custom API not even present
on other AxisArtistHelpers, so deprecate it.
test limits inversion there instead of carrying one bit of state
around.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).