-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
CI: Build merged version on CircleCI #20680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I noticed also that there is no way to skip Azure runs, let me know if you want me to port over the 30 or so lines that allow using Or the SciPy variant that allows having that same thing anywhere in the commit message: (Both were developed originally for MNE by @GuillaumeFavelier !) |
Couldn't resist the temptation to put https://dev.azure.com/matplotlib/matplotlib/_build/results?buildId=20049&view=results I'll push a commit without it in there just to make sure I didn't break the main tests, though... |
Merge step appears to be working: Ready for review/merge from my end |
OK, but maybe the skip command needs to be documented in the dev docs somewhere? Though I'm not sure under what conditions we'd skip Azure versus the other tests... |
For just one example, if you just want to update some documentation wording and make sure you didn't do something bad RST/Sphinx-wise, something like For another example, maintainers doing CI maintenance like in this PR where just I have found having this level of individual control over each CI provider to be pretty useful over the years of maintaining repos. |
Maybe I misunderstood, does this also skip all the GitHub action tests somehow? |
No, I just pushed a doc update that hopefully makes it clearer |
Will push a commit to skip everything except Circle so that we can see that the doc-only change to the devdocs I made doesn't break anything... |
Now you need to commit without skipping Circle though, to see the merging worked. |
You can look at any of the commits that preceded that one above, e.g. https://app.circleci.com/pipelines/github/matplotlib/matplotlib/10541/workflows/1a5c01bb-2de1-4053-90a8-ebdd6898c06c/jobs/62402/parallel-runs/0/steps/0-103. But I'll push another one without any skips once we settle on if the file-based method is good enough or if I need to dig into bash more... |
Merge worked, and it's building: Will now push another commit with |
FYI @QuLogic I fixed up the shell scripting to avoid using files in the process. |
PR Summary
circleci-artifacts-redirector-action
to say "Check the rendered docs here!" as its GitHub status title, but this will only take effect once this PR is merged (because the action is triggered bystatus
and thus always runs on whatever is in the action inmaster
).[skip circle]
and[circle skip]
support to skip CircleCI[skip azp]
and[azp skip]
support to skip Azureskip
options exist, alongside[skip actions]
and[skip appveyor]
(which are natively supported by those platforms)Closes #20658
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).