Deprecate matplotlib.cm.LUTSIZE #20806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Aug 14, 2021
tacaswell
approved these changes
Aug 14, 2021
QuLogic
reviewed
Aug 17, 2021
lib/matplotlib/cm.py
Outdated
| @@ -23,10 +23,20 @@ | |||
| import matplotlib as mpl | |||
| from matplotlib import _api, colors, cbook | |||
| from matplotlib._cm import datad | |||
| import functools | |||
There was a problem hiding this comment.
This belongs with collections.abc in the standard library import block.
There was a problem hiding this comment.
Anybody is welcome to fix this and force-push. I won't be able to do it myself for a couple more days.
There was a problem hiding this comment.
So playing with the new codespaces, review comments on branches that have PRs are inline which is pretty nice!
There was a problem hiding this comment.
but the "mpl contributors can push to my PR branch" ACL does not seem to be forwarded yet. Oh well.
c4d0717 to
0a911e2
Compare
|
and rebased. |
we can directly use `mpl.rcParams['image.lut']`.
0a911e2 to
015985f
Compare
|
Third times the charm, hopefully all of our CI systems have auto-kill setup. |
QuLogic
approved these changes
Aug 17, 2021
9 tasks
lpsinger
added a commit
to lpsinger/matplotlib
that referenced
this pull request
Aug 18, 2021
PR matplotlib#20806 added another instance of a module-level `__getattr__` function that was missing a final `raise AttributeError` to catch unknown attributes. This is the same kind of bug as matplotlib#20822. See also astropy/astropy#12038.
7 tasks
musicinmybrain
added a commit
to musicinmybrain/nipy
that referenced
this pull request
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can directly use
mpl.rcParams['image.lut'].