Clarify tutorial "Customizing Matplotlib with style sheets and rcParams" #20812
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
f3af5c6 to
08bb99d
Compare
08bb99d to
8798842
Compare
|
I hope I understood your concerns correctly and addressed them appropriately. |
Clarify that only the rcParam that is not related to style is ignored instead of the entire style sheet.
* Include `STYLE_BLACKLIST` in the documentation of
`matplotlib.style.use` in alphabetical order.
* Print list of rcParams in `matplotlib.RcParams` in alphabetical
order.
* Fix broken links to `.style.available` in
`lib/matplotlib/style/core.py`.
8798842 to
36fac22
Compare
36fac22 to
117b4a1
Compare
|
Thanks @andthum! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
|
Thank you @QuLogic, and thank you all for your great work on Matplotlib! It was a pleasure to contribute back a tiny piece. |
PR Summary
Closes #20800
The tutorial Customizing Matplotlib with style sheets and rcParams was not clear about what rcParams can be set in style sheets. The blacklist of rcParams that cannot be set in style sheets is now documented in the docstring of
matplotlib.style.useand the tutorial links to this blacklist.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).