-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Implement multi-font embedding for PS Backend #20832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34f5cbb
to
bd11b22
Compare
cb3573c
to
83b227d
Compare
7 tasks
This was referenced Aug 4, 2022
Included in #23559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adding on to the changes from the original PDF PR: #20804, this PR modifies the layout of PS backend to allow embedding multiple fonts.
Currently, Type3 multi-font embedding works fine,
however, Type42 fails to display the glyphs from other font, even after the font is embedded (and subsetted).UPDATE: Using a different font seems to output a good Type42 embedding.
Type3_converted_from_ps.pdf
Type42_converted_from_ps.pdf
^^ Type 3
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).