Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix build error on win32-py2.6 #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2013
Merged

Fix build error on win32-py2.6 #2085

merged 1 commit into from
May 29, 2013

Conversation

cgohlke
Copy link
Contributor

@cgohlke cgohlke commented May 29, 2013

No description provided.

mdboom added a commit that referenced this pull request May 29, 2013
Fix build error on win32-py2.6
@mdboom mdboom merged commit eabe8cc into matplotlib:v1.3.x May 29, 2013
@mdboom
Copy link
Member

mdboom commented May 30, 2013

@cgohlke: I should have vetted this more before merging. This now creates the following message on Python 2.7 and 3.3 on Linux:

warning: manifest_maker: MANIFEST.in, line 12: 'recursive-include' expects <dir> <pattern1> <pattern2> ...

so now the sample data does not get installed.

Does removing the trailing slash, but keeping the space resolve it for you?

recursive-include lib/matplotlib/mpl-data/sample_data *

@mdboom
Copy link
Member

mdboom commented May 30, 2013

Scrap that suggestion -- it doesn't even like that. What didn't work about the original on Windows? Maybe there's another way around that.

@cgohlke
Copy link
Contributor Author

cgohlke commented May 30, 2013

The last line of the traceback on py2.6 is ValueError: path 'lib/matplotlib/mpl-data/sample_data/' cannot end with '/'

recursive-include lib/matplotlib/mpl-data/sample_data * works for me too.

@cgohlke cgohlke deleted the patch-2 branch May 30, 2013 15:55
@mdboom
Copy link
Member

mdboom commented May 30, 2013

Ok. This is resolved by #2095 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants