Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST: Add unit test to catch recurrences of #20822, #20855 #20856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

TST: Add unit test to catch recurrences of #20822, #20855 #20856

wants to merge 1 commit into from

Conversation

lpsinger
Copy link
Contributor

PR Summary

Add a unit test to automatically catch issues like #20822 and #20855.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@lpsinger
Copy link
Contributor Author

Note that the tests for this PR will be expected to fail until #20855 is merged.

@lpsinger lpsinger force-pushed the getattr-attributeerror-test branch 2 times, most recently from 4df44f6 to a5da792 Compare August 18, 2021 16:19
@anntzer anntzer mentioned this pull request Aug 18, 2021
Merged
7 tasks
@lpsinger lpsinger force-pushed the getattr-attributeerror-test branch from a5da792 to e0ae4b0 Compare August 18, 2021 16:25
@lpsinger lpsinger force-pushed the getattr-attributeerror-test branch from e0ae4b0 to 79a0a33 Compare August 19, 2021 02:17
@lpsinger
Copy link
Contributor Author

This should pass now that #20855 has been merged.

@tacaswell tacaswell added this to the v3.5.0 milestone Aug 20, 2021
@tacaswell
Copy link
Member

I cherry-picked this commit into #20857 for a belt-and-suspenders approach.

@QuLogic
Copy link
Member

QuLogic commented Aug 20, 2021

Merged into #20857.

@QuLogic QuLogic closed this Aug 20, 2021
@lpsinger lpsinger deleted the getattr-attributeerror-test branch August 20, 2021 22:14
@tacaswell
Copy link
Member

Thanks @lpsinger ! I made the assumption you would not mind if we cherry-picked your commit to the other PR (and you are not counting merged PRs for a metric someplace), hope you are OK with this.

@lpsinger
Copy link
Contributor Author

Of course, no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lpsinger @tacaswell @QuLogic