[Doc] colors.to_hex input & output #20913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Aug 26, 2021
lib/matplotlib/colors.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| c : Matplotlib color or ``np.ma.masked`` |
There was a problem hiding this comment.
just "color" (we say "color" in a bunch of doc descriptions to mean "matplotlib color"; this is not different).
There was a problem hiding this comment.
I was super confused by what is color - RGBA, named, all of the above? (should color maybe cross link to https://matplotlib.org/devdocs/tutorials/colors/colors.html?)
There was a problem hiding this comment.
Perhaps, but that should probably be another discussion, similar to the joinstyle/capstyle one.
821f268 to
73db5b5
Compare
73db5b5 to
58e8b94
Compare
timhoffm
reviewed
Aug 26, 2021
Co-authored-by: Tim Hoffmann <[email protected]>
Co-authored-by: Tim Hoffmann <[email protected]>
dstansby
reviewed
Sep 13, 2021
Co-authored-by: David Stansby <[email protected]>
timhoffm
approved these changes
Sep 13, 2021
lib/matplotlib/colors.py
Outdated
| ``#rrggbbaa`` otherwise. | ||
| Parameters | ||
| ---------- | ||
| c : :doc:`color </tutorials/colors/colors>` or `np.ma.masked` |
There was a problem hiding this comment.
Suggested change
| c : :doc:`color </tutorials/colors/colors>` or `np.ma.masked` | |
| c : :doc:`color </tutorials/colors/colors>` or `numpy.ma.masked` |
Sorry, need the original name to make the link working.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 13, 2021
dstansby
added a commit
that referenced
this pull request
Sep 13, 2021
…913-on-v3.5.x Backport PR #20913 on branch v3.5.x ([Doc] colors.to_hex input & output)
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
[Doc] colors.to_hex input & output
ericpre
pushed a commit
to ericpre/matplotlib
that referenced
this pull request
Oct 20, 2021
[Doc] colors.to_hex input & output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added numpydoc style documentation of parameters to the colors.to_hex function