Fix documented allowed values for Patch.set_edgecolor. #20937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"auto" was documented as allowed value by 05e4ed9, but AFAICT this was not actually implemented (there's no handling for such a value anywhere in the module).
timhoffm
approved these changes
Aug 29, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 29, 2021
….set_edgecolor.
timhoffm
added a commit
that referenced
this pull request
Aug 29, 2021
…937-on-v3.5.x Backport PR #20937 on branch v3.5.x (Fix documented allowed values for Patch.set_edgecolor.)
|
Thanks for addressing this! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"auto" was documented as allowed value by 05e4ed9 (@efiring), but AFAICT this was
not actually implemented (there's no handling for such a value anywhere
in the module).
Closes #20936.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).