Thanks to visit codestin.com
Credit goes to github.com

Skip to content

set_dashes does not support offset=None anymore. #21051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 11, 2021

This was deprecated in 3.3 (eb76378) and removed in most places in
c51ae6d; this patch removes supports on the C side and mentions of it
in docs.

Also remove the dashobj == NULL && dashobj == Py_None check, which can
never be true.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

This was deprecated in 3.3 (eb76378) and removed in most places in
c51ae6d; this patch removes supports on the C side and mentions of it
in docs.

Also remove the `dashobj == NULL && dashobj == Py_None` check, which can
never be true.
@timhoffm timhoffm added this to the v3.5.0 milestone Sep 12, 2021
@QuLogic QuLogic merged commit 1a0ebbb into matplotlib:master Sep 13, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 13, 2021
@anntzer anntzer deleted the gdbdashes branch September 14, 2021 00:21
QuLogic added a commit that referenced this pull request Sep 14, 2021
…051-on-v3.5.x

Backport PR #21051 on branch v3.5.x (set_dashes does not support offset=None anymore.)
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
set_dashes does not support offset=None anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants