Deprecate support for no-args MarkerStyle(). #21056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Sep 13, 2021
|
Maybe remove the weird docstring sentence:
|
|
Reworded. Unfortunately the situation is still slightly confusing (see new wording). Actually deprecating support for |
As noted in the module docstring, there is a confusion between using a generic default MarkerStyle (empty) and the artist-specific one (e.g. scatter plots use `rcParams["scatter.marker"]`). Fortunately, direct construction of MarkerStyles (especially of empty ones) is hardly ever needed, so we can just make the parameter required.
jklymak
approved these changes
Sep 13, 2021
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Deprecate support for no-args MarkerStyle().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the module docstring, there is a confusion between using a
generic default MarkerStyle (empty) and the artist-specific one (e.g.
scatter plots use
rcParams["scatter.marker"]). Fortunately, directconstruction of MarkerStyles (especially of empty ones) is hardly ever
needed, so we can just make the parameter required.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).