Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix typo in template of current dev-docs #21062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

deep-jkl
Copy link
Contributor

PR Summary

I was recently working on some documentation and the new template took my attention, it looks great, good work. I found an typo in the main navigation bar Tutoraials -> Tutorials. Despite the fact that this is a single character PR I believe it has major impact and this will ease the process. I have not done any proof reading of the new documentation.

PR Checklist

  • [ N/A ] Has pytest style unit tests (and pytest passes).
  • [ N/A ] Is Flake 8 compliant (run flake8 on changed files to check).
  • [ N/A ] New features are documented, with examples if plot related.
  • [ ] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [ N/A ] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [ N/A ] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [ N/A ] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 13, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.4.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 d27fba34e8b99bc2ebc48c502530d8376a1b19ce
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #21062: Fix typo in template of current dev-docs'
  1. Push to a named branch :
git push YOURFORK v3.4.x:auto-backport-of-pr-21062-on-v3.4.x
  1. Create a PR against branch v3.4.x, I would have named this PR:

"Backport PR #21062 on branch v3.4.x (Fix typo in template of current dev-docs)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove Still Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free to suggest an improvement.

@dstansby dstansby modified the milestones: v3.4.4, v3.5.0 Sep 13, 2021
dstansby added a commit that referenced this pull request Sep 13, 2021
…062-on-v3.5.x

Backport PR #21062 on branch v3.5.x (Fix typo in template of current dev-docs)
@tacaswell
Copy link
Member

Thank you @deep-jkl !

tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Fix typo in template of current dev-docs
@deep-jkl deep-jkl deleted the typo-in-new-doc-template branch April 13, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants