Fix format_cursor_data with nans. #21145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, hovering the mouse over a nan pixel in an imshow() would result in `Warning: converting a masked element to nan.` and then `ValueError: cannot convert float NaN to integer`. Fix that. The format_cursor_data test doesn't explicitly check the return value of get_cursor_data anymore because np.ma.masked is returned for nan inputs (this is expected from the general approach for handling invalid data); checking that format_cursor_data gives the right string is sufficient.
QuLogic
approved these changes
Sep 21, 2021
timhoffm
approved these changes
Sep 22, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 22, 2021
jklymak
added a commit
that referenced
this pull request
Sep 22, 2021
…145-on-v3.5.x Backport PR #21145 on branch v3.5.x (Fix format_cursor_data with nans.)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Fix format_cursor_data with nans.
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Fix format_cursor_data with nans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, hovering the mouse over a nan pixel in an imshow()
would result in
Warning: converting a masked element to nan.and thenValueError: cannot convert float NaN to integer. Fix that.The format_cursor_data test doesn't explicitly check the return value
of get_cursor_data anymore because np.ma.masked is returned for nan
inputs (this is expected from the general approach for handling invalid
data); checking that format_cursor_data gives the right string is
sufficient.
Regression coming from #20949.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).