DOC: Fix source links and flake8 cleanup #21240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Oct 1, 2021
| @@ -12,6 +12,7 @@ colorspacious | |||
| ipython | |||
| ipywidgets | |||
| numpydoc>=0.8 | |||
| packaging>=20 | |||
There was a problem hiding this comment.
Please also add to environment.yml.
Instead of figuring out a regex ourselves, just use `packaging` to determine the version. And point to `master` branch if not on an actual tag. Fixes matplotlib#21230
timhoffm
approved these changes
Oct 1, 2021
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove If these instruction are inaccurate, feel free to suggest an improvement. |
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Oct 1, 2021
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Oct 1, 2021
timhoffm
added a commit
that referenced
this pull request
Oct 1, 2021
…3.5.x Backport PR #21240: DOC: Fix source links and flake8 cleanup
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
DOC: Fix source links and flake8 cleanup
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
DOC: Fix source links and flake8 cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Instead of trying to figure out a regex, just use
packagingto parse the version, and link to eithermasterbranch or a tag directly if a release.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).