Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Fix source links to prereleases #21260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Oct 1, 2021

PR Summary

We normally replace prerelease docs with final anyway, but until that time, the links using Version.base_version would point to the final tag, which won't exist yet. But Version.public includes the prerelease part and should point to the right tag.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@timhoffm timhoffm merged commit f657b37 into matplotlib:master Oct 1, 2021
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 1, 2021

Something went wrong ... Please have a look at my logs.

@QuLogic QuLogic deleted the doc-prerel branch October 1, 2021 22:00
@QuLogic
Copy link
Member Author

QuLogic commented Oct 1, 2021

That backport was included in #21261, no need to worry about @meeseeksdev.

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Oct 12, 2021
DOC: Fix source links to prereleases
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
DOC: Fix source links to prereleases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants