Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Disable blitting on GTK4 backends #21294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Oct 6, 2021

PR Summary

It is not possible to queue a draw for a subregion of a widget, so this crashes. Since 3.5 is feature frozen, disable blitting for now to make animations work.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. GUI: gtk labels Oct 6, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone Oct 6, 2021
@QuLogic QuLogic force-pushed the no-gtk4-blit branch 2 times, most recently from ebab29a to 352a390 Compare October 6, 2021 04:29
It is not possible to queue a draw for a subregion of a widget, so this
crashes. Since 3.5 is feature frozen, disable blitting for now to make
animations work.
@anntzer
Copy link
Contributor

anntzer commented Oct 6, 2021

can selfmerge postci.

@QuLogic QuLogic merged commit a698063 into matplotlib:master Oct 6, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 6, 2021
@QuLogic QuLogic deleted the no-gtk4-blit branch October 6, 2021 23:54
tacaswell added a commit that referenced this pull request Oct 7, 2021
…294-on-v3.5.x

Backport PR #21294 on branch v3.5.x (Disable blitting on GTK4 backends)
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Oct 12, 2021
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Disable blitting on GTK4 backends
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: gtk Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants