-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: use mpl-sphinx-theme for navbar, social, logo #21429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(Note, probably not crucial for 3.5.0) |
8a6d8b5
to
58da13c
Compare
This works now - mol-sphinx-theme had a bug... |
ebfb905
to
acaedac
Compare
2c1b72a
to
3b406ff
Compare
The only disadvatage I see with this concept is that we don't see how the resulting pages look like when changing the mpl-sphinx-theme. After updating the theme, all downstream sites have to be rebuilt as well. |
Mpl-Sphinx-theme has a doc build. These docs are built at release time, and devdocs are built periodically. The other docs are built when changed, but we could also add a "daily" build to them all. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove If these instruction are inaccurate, feel free to suggest an improvement. |
DOC: use mpl-sphinx-theme for navbar, social, logo
DOC: use mpl-sphinx-theme for navbar, social, logo
Backport #21429 from jklymak/doc-use-mpl-sphinx
PR Summary
Switches main site to use mpl-sphinx-theme
Note at some point we need to consider pinning this for releases.
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).