Thanks to visit codestin.com
Credit goes to github.com

Skip to content

set_ticks([single_tick]) should also expand view limits. #21431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2021
Merged

set_ticks([single_tick]) should also expand view limits. #21431

merged 1 commit into from
Oct 24, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 22, 2021

Previously, the single-tick case would not perform expansion.

(Curiously, the len > 1 check was added in 0b48047 to fix inversion
handling, and then cb5cab4 tried another fix apparently for the same
problem (by making set_view_limits maintain preexisting inversions).
@efiring do you remember what you did >10y ago? :-))

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer changed the title (Curiously, the len > 1 check was added in 0b48047 to fix inversion handling, and then cb5cab4 tried another fix apparently for the same problem (by making set_view_limits maintain preexisting inversions).)set_ticks([single_tick]) should also expand view limits. set_ticks([single_tick]) should also expand view limits. Oct 22, 2021
@anntzer
set_ticks([single_tick]) should also expand view limits.
5ab9436 
Previously, the single-tick case would not perform expansion.

(Curiously, the `len > 1` check was added in 0b48047 to fix inversion
handling, and then cb5cab4 tried another fix apparently for the same
problem (by making set_view_limits maintain preexisting inversions).)
efiring
efiring approved these changes Oct 24, 2021
View reviewed changes
Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why I originally required more than one tick, and then later also questioned why setting ticks should change the view limits. In any case, the change here looks fine to me.

@efiring efiring merged commit f1087cc into matplotlib:main Oct 24, 2021
@anntzer anntzer deleted the st1 branch October 24, 2021 18:36
@QuLogic QuLogic added this to the v3.6.0 milestone Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: ticks axis labels
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @efiring @dstansby @QuLogic