Also exclude pyparsing 3.0.0 in setup.py. #21446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The other pins use <3 not !=3. Is this a bug in pyparsing or an API change we have to adapt to? |
|
I did less than 3.0.0 pending investigation to get CI to work. I'm not sure what the permanent solution is. |
|
Yeah, I think |
|
|
timhoffm
approved these changes
Oct 24, 2021
|
Anybody can merge after CI pass. |
|
@meeseeksdev backport to v3.5.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 24, 2021
timhoffm
added a commit
that referenced
this pull request
Oct 24, 2021
…446-on-v3.5.x Backport PR #21446 on branch v3.5.x (Also exclude pyparsing 3.0.0 in setup.py.)
|
Any idea when this might get released? I'd like to avoid having to do the same cap on pyparsing in our project (which pulls in matplotlib as a transitive dependency, we don't require pyparsing directly) if we can just get it this way. |
|
Hopefully this week, we have 1 blocking issue left for 3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).