Un-pin pyparsing to see if pyparsing 3.0.3 works on main #21489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
with pyparsing 3.0.3 we see shifts in some math formulas: Can it be that this is caused by the change to pyparsing >=3? e.g. for got: |
|
It looks like a leading space was included or not included (I can't tell which is the before and which is the after in your diff). I'm trying to test your parser in isolation, but I keep having to pull in more and more code. Is there a way to test without doing the whole Anaconda installation? |
|
Have you used the |
|
Superseded by #21501. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Pyparsing 3.0.0 introduced some backward-incompatible changes. As a result, we pinned it in #21445 + #21446.
Let's see if this is fixed in the more recent versions of pyparsing.