Fix transparency when exporting to png via pgf backend. #21557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and add a private mechanism ($_MPLHIDEEXECUTABLES) to allow manually testing both pdftocairo and ghostscript. No automation for that, sorry.
jklymak
reviewed
Nov 22, 2021
| '-r%d' % dpi, pdffile] | ||
| subprocess.check_output(cmd, stderr=subprocess.STDOUT) | ||
| return gs_convert | ||
| return lambda pdffile, pngfile, dpi: subprocess.check_output( |
There was a problem hiding this comment.
For symmetry with the case above; as to why both are lambdas: to avoid running afoul of pep8's request of blank lines around function definitions (even if we don't explicitly check that here) without introducing a bunch of blank lines.
When immediately returning a function, I also find return lambda ... easier to read (when the lambda body is indeed a single expression), as that puts the intent ("this is what I'm returning") earlier, but YMMV...
There was a problem hiding this comment.
No opinion on functions vs lambdas. 😎
timhoffm
approved these changes
Nov 22, 2021
QuLogic
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and add a private mechanism ($_MPLHIDEEXECUTABLES) to allow manually
testing both pdftocairo and ghostscript. No automation for that, sorry.
Closes #11738.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).