Fix eventplot units #21559
Merged
Fix eventplot units #21559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TST: add test for eventplot
a94fca0 to
2ba8144
Compare
story645
approved these changes
Nov 7, 2021
|
Since this seems to be a regression fix? (since it sometimes worked) should it get backported to 3.5? |
|
I guess I'm not sure it ever worked? |
|
@efiring said it did? |
|
@meeseeksdev backport to v3.5.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 8, 2021
jklymak
added a commit
that referenced
this pull request
Nov 8, 2021
…559-on-v3.5.x Backport PR #21559 on branch v3.5.x (Fix eventplot units)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #21552
positions in event plot can be a list of lists, but our unit-processing machinery only handles array-like, so process each element of the list separately after we have turned arbitrary inputs into a list of lists.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).