[BUG in 3.5.0rc1] - Anatomy of a Figure has the legend in the wrong spot #21592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Nov 10, 2021
tacaswell
approved these changes
Nov 10, 2021
|
Odd, circle missed this PR somehow (which is the one we actually need to run!) |
|
Thank you for catching this @stefmolin ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 11, 2021
… has the legend in the wrong spot
|
My pleasure! This is a great resource for newcomers (I'm using it in a workshop I'm developing), so I'm glad I caught it 🙂 |
tacaswell
added a commit
that referenced
this pull request
Nov 11, 2021
…592-on-v3.5.x Backport PR #21592 on branch v3.5.x ([BUG in 3.5.0rc1] - Anatomy of a Figure has the legend in the wrong spot)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In 3.5.0rc1, the call to
ax.legend()in the Anatomy of a figure example is now placing the legend in the lower right corner:In version 3.4.3, this call is determining that the "upper right" is the best location for the legend so the example works. I modified the call to
ax.legend()to specifyloc="upper right"to ensure we always have the legend in the correct spot.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).