[SPRINT] Much better alpha control in mplot3d. Closes #1541 #2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably haven't solved them all, but this gets most of them.
|
Again, errors appear to be either the new weirdness with loader or some other error with fonts unrelated to my work. |
|
We should probably add a test for this. |
|
+1 for the test. After that I think it's good to go. I don't think it has to be an image test. |
|
@WeatherGod - do you mind rebasing, and we can merge this. I don't know if we have any tests for mplot3d yet, so I'm prepared to merge without a test at this point. |
|
Uhm, I am having a vague recollection that I encountered some issues with |
|
Ok. Closing until its ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably haven't solved them all, but this gets most of them.
Edit: Damon here. I edited the title of this to contain the word 'sprint'.