FIX: deprecation of render keyword to do_3d_projection #21704
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we both warned and required that renderer be an accepted argument.
jklymak
approved these changes
Nov 22, 2021
QuLogic
reviewed
Nov 22, 2021
| super().__init__((0, 0), (0, 0), *args, **kwargs) | ||
| self._verts3d = xs, ys, zs | ||
|
|
||
| def do_3d_projection(self, render): |
There was a problem hiding this comment.
Suggested change
| def do_3d_projection(self, render): | |
| def do_3d_projection(self, renderer): |
| a = Arrow3D([0, 10], [0, 0], [0, 0], **arrow_prop_dict) | ||
| ax.add_artist(a) | ||
|
|
||
| with pytest.warns(MatplotlibDeprecationWarning): |
There was a problem hiding this comment.
I think you should add a match for the specific warning text you want here.
2 tasks
|
Closing in favor of #21741 |
|
i got this problem from the given code of the book math for programers by Paul Orland |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we both warned and required that renderer be an accepted argument.
After this is merged there should be a follow up to remove this entire code path.
PR Summary
Noticed this while debugging #21688
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).