MNT: make print_figure kwarg wrapper support py311 #21705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not fully understand what changed, but without this change `walk_stack` would start 2 frames higher (in the test module, not in backend_bases) which would mean we never saw the frame with `print_figure` and hence was getting warnings which we converted to failures on a vast majority of the tests. I suspect that this is related to the fast-Python work and avoiding making unneeded structures during the calls, but chased that theory down yet. Discovered on a commit between py311a2 and py311a3.
We should have pulled this out in mpl3.5
|
#21395 is a possible implementation of the followup (which I agree is too large for a patch release). |
|
Ah, great, I missed that PR existed. Glad I did not waste time trying to sort out how to do that removal :) |
jklymak
approved these changes
Nov 24, 2021
dstansby
approved these changes
Nov 28, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 28, 2021
dstansby
added a commit
that referenced
this pull request
Nov 28, 2021
…705-on-v3.5.x Backport PR #21705 on branch v3.5.x (MNT: make print_figure kwarg wrapper support py311)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Do not fully understand what changed, but without this change
walk_stackwould start 2 frames higher (in the test module, not in backend_bases) which
would mean we never saw the frame with
print_figureand hence was gettingwarnings which we converted to failures on a vast majority of the tests.
I suspect that this is related to the fast-Python work and avoiding making
unneeded structures during the calls, but chased that theory down yet.
Discovered on a commit between py311a2 and py311a3.
This will need a followup PR to main that rips out almost all of this code. We should have ripped it out in mpl35, but do not think we should do that in a patch release so also updated the deprecation date.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).