Refix check for manager presence in deprecated blocking_input. #21791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole module has been deprecated as the library is now using _blocking_input, which does not have the same problem, but it still seems better to fix this typo asap.
QuLogic
approved these changes
Nov 29, 2021
timhoffm
approved these changes
Nov 29, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 29, 2021
…recated blocking_input.
QuLogic
added a commit
that referenced
this pull request
Nov 30, 2021
…791-on-v3.5.x Backport PR #21791 on branch v3.5.x (Refix check for manager presence in deprecated blocking_input.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole module has been deprecated as the library is now using
_blocking_input, which does not have the same problem, but it still
seems better to fix this typo asap.
Closes #21553 (comment); compare https://github.com/matplotlib/matplotlib/pull/21553/files#diff-40db16a7cd74c616dae604fc6676f18401651520bc8bff358d27b8d2b4b0862f.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).