Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Backport PR #21663 on branch v3.5.x (Use standard subplot window in macosx backend) #21806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Nov 29, 2021

PR Summary

Backport PR #21663 on branch v3.5.x (Use standard subplot window in macosx backend)

@QuLogic QuLogic added this to the v3.5.1 milestone Nov 29, 2021
@QuLogic
Copy link
Member Author

QuLogic commented Nov 29, 2021

@greglucas can you check there's no issue with the backport?

@greglucas
Copy link
Contributor

The scaling all looks good to me jumping between the monitors, but now there is another issue of the updates not triggering a draw. On 3.5.0 when I move the slider, the window immediately updates the draw. Here, the slider moves, but there is no visual response. But, if I go into pan mode and click on the plot, the canvas is updated with the proper scaling I had selected.

Note that on 3.5.0, it is not flawless for me, I can slide the bar around for a bit and then all of a sudden it freezes on me and interactivity is gone. So there is something odd going on there too.

@QuLogic
Copy link
Member Author

QuLogic commented Nov 30, 2021

Could be related to the flush_events-type stuff?

Anyway, I'll merge this now as that seems something else.

@QuLogic QuLogic merged commit 43dad62 into matplotlib:v3.5.x Nov 30, 2021
@QuLogic QuLogic deleted the macos-backport branch November 30, 2021 02:40
@greglucas
Copy link
Contributor

👍 Yes, I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants