Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MNT: Turn all macosx warnings into errors while building #21809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2021
Merged

MNT: Turn all macosx warnings into errors while building #21809

merged 1 commit into from
Nov 30, 2021

Conversation

greglucas
Copy link
Contributor

PR Summary

Change to -Werror to catch all warnings during build on mac machines.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

QuLogic
QuLogic approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have passed without error.

@QuLogic QuLogic added this to the v3.6.0 milestone Nov 30, 2021
@jklymak jklymak merged commit 505cdff into matplotlib:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
GUI: MacOSX
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@greglucas @QuLogic @jklymak