Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Backport PR #21913 on branch v3.5.x (Make colorbar boundaries work again) #21926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2021
Merged

Backport PR #21913 on branch v3.5.x (Make colorbar boundaries work again) #21926

merged 2 commits into from
Dec 11, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Dec 10, 2021 •
edited
Loading

PR Summary

Backport #21913, and also #21137 to fix conflicts.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

anntzer and others added 2 commits December 10, 2021 18:04
@anntzer @QuLogic
Small cleanups to colorbar.
68e9b15 
- `__scale = "manual"` doesn't exist anymore since d1c5a6a.
- Shorten Boundary/NoNorm inversion and norm._scale check.
- No need to define `x` well before its use point, and no need to make
  it an array explicitly.
@QuLogic
Backport PR matplotlib#21913: Make colorbar boundaries work again
6d14827
@QuLogic QuLogic added this to the v3.5.1 milestone Dec 10, 2021
greglucas
greglucas approved these changes Dec 11, 2021
View reviewed changes
Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it with the 3d example from the issue and everything looks good there with the boundaries being respected.

@QuLogic QuLogic merged commit 2d84c62 into matplotlib:v3.5.x Dec 11, 2021
@QuLogic
Copy link
Member Author

QuLogic commented Dec 11, 2021

Thanks!

@QuLogic QuLogic deleted the auto-backport-of-pr-21913-on-v3.5.x branch December 11, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
topic: color/colorbar
Projects
None yet
Milestone
v3.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @greglucas @anntzer