Removed loaded modules logging #21980
Conversation
|
@tacaswell I added a note in next_api_changes under the removals folder documenting this change. Is it enough? |
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
| Removed logging | ||
| ~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Removed `loaded modules` logging because it can produce extensive output. |
There was a problem hiding this comment.
Maybe something more like "The list of currently loaded modules is no longer logged at the DEBUG level at Matplotlib import time. If you were relying on this please arrange for your own logging." ?
There was a problem hiding this comment.
This is going to be read by people maybe a few years in the future so it needs to have enough context that it makes sense without tracking down the issue that this PR closed.
There was a problem hiding this comment.
I think the message is more helpful now.
761b464 to
96376fa
Compare
96376fa to
91995cd
Compare
|
Looks good to me @cavesdev . Now we wait for a second review :) |
|
Thanks @cavesdev! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
This is just a one-line change. Closes #21978