PEP8ify wx callback names. #21991
Merged
PEP8ify wx callback names. #21991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are all private (OnClose lives on the private _HelpDialog class), and they weren't following wx's TitleCaseIncludingFirstWord either anyways.
QuLogic
approved these changes
Dec 17, 2021
QuLogic
requested changes
Dec 17, 2021
|
|
||
| def OnClose(self, event): |
There was a problem hiding this comment.
Wait, this one isn't a binding, and didn't match the old name.
There was a problem hiding this comment.
It's just a normal method on a private class, so I renamed it at the same time.
There was a problem hiding this comment.
Yep, oops, I missed the binding on this one.
QuLogic
approved these changes
Dec 17, 2021
|
|
||
| def OnClose(self, event): |
There was a problem hiding this comment.
Yep, oops, I missed the binding on this one.
timhoffm
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are all private (OnClose lives on the private _HelpDialog class),
and they weren't following wx's TitleCaseIncludingFirstWord either
anyways.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).