Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify wx _print_image. #22020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Simplify wx _print_image. #22020

merged 1 commit into from
Dec 21, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 20, 2021

Instead of swapping the bitmap attribute, it is enough to create a new
renderer with a different target and save that target to a file.

The isinstance(..., wx.Image) check is always false (we have a wx.Bitmap
instead), so skip it.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer anntzer added this to the v3.6.0 milestone Dec 20, 2021
Instead of swapping the bitmap attribute, it is enough to create a new
renderer with a different target and save that target to a file.

The isinstance(..., wx.Image) check is always false (we have a wx.Bitmap
instead), so skip it.
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@timhoffm timhoffm merged commit a402aa1 into matplotlib:main Dec 21, 2021
@anntzer anntzer deleted the wxpi branch December 21, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants