Simplify wxframe deletion. #22026
Merged
Simplify wxframe deletion. #22026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Dec 22, 2021
greglucas
reviewed
Jan 29, 2022
| @@ -951,24 +951,13 @@ def _on_close(self, event): | |||
| self.figmgr.frame = None | |||
| # remove figure manager from Gcf.figs | |||
| Gcf.destroy(self.figmgr) | |||
| try: # See issue 2941338. | |||
There was a problem hiding this comment.
Where is issue 2941338? I can't find it anywhere and googling just leads me back to this code block.
There was a problem hiding this comment.
Probably that was on the old sourceforge tracker. It's probably not really useful anymore (I can't find it either), but I didn't want to bother removing it. I can, though, if you prefer.
There was a problem hiding this comment.
I'm indifferent... I usually agree with leaving comments in the code, but when they lead to nowhere it can also lead to confusion.
This one needs a rebase too.
There was a problem hiding this comment.
left it for now, and rebased.
Instead of reimplementing Destroy and fiddling around with supercalls and IsBeingDeleted, move the toolbar disconnection to the _on_close handler (which anyways already unregisters the figure from Gcf, so it's definitely going to destroy the figure) and inherit Destroy from the base class.
greglucas
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reimplementing Destroy and fiddling around with supercalls
and IsBeingDeleted, move the toolbar disconnection to the _on_close
handler (which anyways already unregisters the figure from Gcf, so it's
definitely going to destroy the figure) and inherit Destroy from the
base class.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).