Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Keep FontEntry helpers private. #22042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2021
Merged

Keep FontEntry helpers private. #22042

merged 1 commit into from
Dec 23, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 23, 2021

They are not released yet (they came in in #21904) and don't need to be made public.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Keep FontEntry helpers private.
76c614c 
They are not released yet and don't need to be made public.
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Dec 23, 2021
@anntzer anntzer added this to the v3.6.0 milestone Dec 23, 2021
@timhoffm timhoffm merged commit 62a299f into matplotlib:main Dec 23, 2021
@anntzer anntzer deleted the fep branch December 23, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm