Make required_interactive_framework required on FigureCanvas. #22051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All FigureCanvas subclasses that inherit from FigureCanvasBase already have that attribute (which may be None), so the getattr is redundant. In practice, it would be extremely difficult to write a FigureCanvasLike class that does not inherit from FigureCanvasBase, but to be safe, go through a deprecation period.
tacaswell
approved these changes
Dec 24, 2021
QuLogic
approved these changes
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All FigureCanvas subclasses that inherit from FigureCanvasBase already
have that attribute (which may be None), so the getattr is redundant.
In practice, it would be extremely difficult to write a FigureCanvasLike
class that does not inherit from FigureCanvasBase, but to be safe, go
through a deprecation period.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).